Re: DDL result is lost by CREATE DATABASE with WAL_LOG strategy - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: DDL result is lost by CREATE DATABASE with WAL_LOG strategy
Date
Msg-id 20230216000659.GA1932550@nathanxps13
Whole thread Raw
In response to DDL result is lost by CREATE DATABASE with WAL_LOG strategy  ("Ryo Matsumura (Fujitsu)" <matsumura.ryo@fujitsu.com>)
Responses Re: DDL result is lost by CREATE DATABASE with WAL_LOG strategy
List pgsql-hackers
On Wed, Feb 15, 2023 at 04:49:38AM +0000, Ryo Matsumura (Fujitsu) wrote:
> The above is occured by the following call.
> The argument 'permanent' of ReadBufferWithoutRelcache() is passed to
> BufferAlloc() as 'relpersistence'.
> 
> [src/backend/commands/]
>  298         buf = ReadBufferWithoutRelcache(rnode, MAIN_FORKNUM, blkno,
>  299                                         RBM_NORMAL, bstrategy, false);

Indeed, setting that to true (as per the attached patch) seems to fix this.
I don't see any reason this _shouldn't_ be true from what I've read so far.
We're reading pg_class, which will probably never be UNLOGGED.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Perform streaming logical transactions by background workers and parallel apply
Next
From: Tom Lane
Date:
Subject: Re: Silent overflow of interval type