Re: OOM in spgist insert - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: OOM in spgist insert
Date
Msg-id CAFiTN-ss4weC-qxV=UZxtAFzWDs6J_ZF3FEF9b9JahSGDHgUKg@mail.gmail.com
Whole thread Raw
In response to Re: OOM in spgist insert  (Pavel Borisov <pashkin.elfe@gmail.com>)
Responses Re: OOM in spgist insert
List pgsql-hackers
On Wed, May 12, 2021 at 5:11 PM Pavel Borisov <pashkin.elfe@gmail.com> wrote:
>>
>> V2 works.  Thanks for fixing this quickly,  I think you can add a
>> comment for the new error condition you added.
>
> Added comments. PFA v3

Thanks.

+ *
+ * For indexes with INCLUDEd columns we do not know whether we can reduce
+ * index tuple size by suffixing its key part or we will go into the
+ * endless loop on pick-split (in case included columns data is big enough

 INCLUDEd -> why you have used a mixed case here?

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Valentin Nastasache
Date:
Subject: Re: BUG #15293: Stored Procedure Triggered by Logical Replication is Unable to use Notification Events
Next
From: Pavel Borisov
Date:
Subject: Re: OOM in spgist insert