On Thu, Nov 12, 2020 at 11:29 AM Dilip Kumar <dilipbalaut@gmail.com> wrote: > > On Thu, Nov 12, 2020 at 8:45 AM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > > Another thing I am thinking let's just not expose skip_empty_stream to > > the user and consider the behavior based on the value of > > skip_empty_xacts. Internally, in the code, we can still have different > > variables to distinguish between empty_xacts and empty_streams. > > Yeah, even I think in most of the cases it makes more sense to have > skip_empty_xacts and skip_empty_stream similar values. So better we > don't expose skip_empty_stream. I agree that we need to keep two > variables to track the empty stream and empty xacts. >
So, let's try to do this way and if we see any problems then we can re-think.