Re: pg_rewind WAL segments deletion pitfall - Mailing list pgsql-hackers

From Alexander Kukushkin
Subject Re: pg_rewind WAL segments deletion pitfall
Date
Msg-id CAFh8B=nNJtm9ke4_1mhpwGz2PV9yoyF6hMnYh5XACt0AA4VG-A@mail.gmail.com
Whole thread Raw
In response to Re: pg_rewind WAL segments deletion pitfall  (torikoshia <torikoshia@oss.nttdata.com>)
Responses Re: pg_rewind WAL segments deletion pitfall
List pgsql-hackers
Hi Torikoshia,


On Thu, 2 Nov 2023 at 04:24, torikoshia <torikoshia@oss.nttdata.com> wrote:


> +extern void preserve_file(char *filepath);

Is this necessary?
This function was defined in older version patch, but no longer seems to
exist.

+# We use "perl -e 'exit(1)'" as a alternative to "false", because the
last one
'a' should be 'an'?


Thanks for the feedback

Please find the new version attached.

Regards,
--
Alexander Kukushkin

On Thu, 2 Nov 2023 at 04:24, torikoshia <torikoshia@oss.nttdata.com> wrote:
On 2023-10-31 00:26, Alexander Kukushkin wrote:
> Hi,
>
> On Wed, 18 Oct 2023 at 08:50, torikoshia <torikoshia@oss.nttdata.com>
> wrote:
>
>> I have very minor questions on the regression tests mainly regarding
>> the
>> consistency with other tests for pg_rewind:
>
> Please find attached a new version of the patch. It addresses all your
> comments.

Thanks for updating the patch!

> +extern void preserve_file(char *filepath);

Is this necessary?
This function was defined in older version patch, but no longer seems to
exist.

+# We use "perl -e 'exit(1)'" as a alternative to "false", because the
last one
'a' should be 'an'?


--
Regards,

--
Atsushi Torikoshi
NTT DATA Group Corporation


--
Regards,
--
Alexander Kukushkin
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: apply pragma system_header to python headers
Next
From: Alexander Lakhin
Date:
Subject: Re: Support run-time partition pruning for hash join