<div dir="ltr"><br />On Thu, Apr 17, 2014 at 9:15 PM, Michael Paquier <<a
href="mailto:michael.paquier@gmail.com">michael.paquier@gmail.com</a>>wrote:<br />><br />> On Fri, Apr 18,
2014at 4:29 AM, Fabrízio de Royes Mello<br /> > <<a
href="mailto:fabriziomello@gmail.com">fabriziomello@gmail.com</a>>wrote:<br />> ><br />> > On Thu, Apr
17,2014 at 12:46 PM, Bruce Momjian <<a href="mailto:bruce@momjian.us">bruce@momjian.us</a>> wrote:<br /> >
>><br/>> >> On Thu, Apr 17, 2014 at 11:44:37AM -0400, Tom Lane wrote:<br />> >> > Bruce
Momjian<<a href="mailto:bruce@momjian.us">bruce@momjian.us</a>> writes:<br />> >> > > The idea is
thatwe only need quotes when there are odd characters in<br /> > >> > > the identifier. We do that
rightnow in some places, though I can't<br />> >> > > find them in pg_dump. I know psql does that, see
quote_ident().<br/>> >> ><br />> >> > I think our general style rule is that identifiers
embeddedin messages<br /> > >> > are always double-quoted. There's an exception for type names, but<br
/>>>> > not otherwise. You're confusing the message case with printing SQL.<br />> >><br />>
>>OK. I was unclear if a status _display_ was a message like an error<br /> > >> message.<br />>
>><br/>> ><br />> > The attached patch fix missing double-quoted in "dumping contents of<br />>
>table.." message and add schema name to other messages:<br />> > - "reading indexes for table
\"%s\".\"%s\"\n"<br/> > > - "reading foreign key constraints for table \"%s\".\"%s\"\n"<br />> > - "reading
triggersfor table \"%s\".\"%s\"\n"<br />> ><br />> > - "finding the columns and types of table
\"%s\".\"%s\"\n"<br/> > > - "finding default expressions of table \"%s\".\"%s\"\n"<br />> > - "finding
checkconstraints for table \"%s\".\"%s\"\n"<br />> Cool additions. There may be a more elegant way to check if
namespace<br/> > is NULL, but I couldn't come up with one myself. So patch may be fine.<br />><br /><br />Hi
all,<br/><br />I think this small patch was lost. There are something wrong?<br /><br />Regards,<br /><br />--<br
/>Fabríziode Royes Mello<br /> Consultoria/Coaching PostgreSQL<br />>> Timbira: <a
href="http://www.timbira.com.br">http://www.timbira.com.br</a><br/>>> Blog sobre TI: <a
href="http://fabriziomello.blogspot.com">http://fabriziomello.blogspot.com</a><br/> >> Perfil Linkedin: <a
href="http://br.linkedin.com/in/fabriziomello">http://br.linkedin.com/in/fabriziomello</a><br/>>> Twitter: <a
href="http://twitter.com/fabriziomello">http://twitter.com/fabriziomello</a></div>
