Re: [GENERAL] currval and DISCARD ALL - Mailing list pgsql-hackers

From Fabrízio de Royes Mello
Subject Re: [GENERAL] currval and DISCARD ALL
Date
Msg-id CAFcNs+pEOb4oteyVX_mxxtcQfKOPnK2swaOGT=Lo-4yY3kCEog@mail.gmail.com
Whole thread Raw
In response to Re: [GENERAL] currval and DISCARD ALL  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [GENERAL] currval and DISCARD ALL
Re: [GENERAL] currval and DISCARD ALL
Re: [GENERAL] currval and DISCARD ALL
List pgsql-hackers

On Fri, Apr 19, 2013 at 11:12 AM, Robert Haas <robertmhaas@gmail.com> wrote:
On Fri, Apr 19, 2013 at 10:05 AM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:
> The attached wip patch do that and introduce a subcommand 'SEQUENCES', but
> if we decide to don't add a new subcommand to DISCARD, then its easier to
> modify the patch.

This patch is quite wrong.  It frees seqtab without clearing the
pointer, so the next reference will stomp on memory that may have been
reallocated.  And it doesn't even free seqtab correctly, since it only
frees the first node in the linked list.


Ohh sorry... you're all right... I completely forgot to finish the ReleaseSequenceCaches to transverse 'seqtab' linked list and free each node. 

The attached patch have this correct code.

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: elog() error, trying CURENT OF with foreign table
Next
From: Alvaro Herrera
Date:
Subject: Re: [GENERAL] currval and DISCARD ALL