Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED - Mailing list pgsql-hackers

From Fabrízio de Royes Mello
Subject Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED
Date
Msg-id CAFcNs+p=F0+kzmEr3vwGSvSM95ifm_X5w9L4eRgh6odAWnm5Og@mail.gmail.com
Whole thread Raw
In response to Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers

On Sat, Nov 15, 2014 at 2:23 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>
> Michael Paquier wrote:
>
> > Btw, perhaps this diff should be pushed as a different patch as this is a
> > rather different thing:
> > -       if (heapRelation->rd_rel->relpersistence == RELPERSISTENCE_UNLOGGED
> > &&
> > +       if (indexRelation->rd_rel->relpersistence ==
> > RELPERSISTENCE_UNLOGGED &&
> >                 !smgrexists(indexRelation->rd_smgr, INIT_FORKNUM)
> > As this is a correctness fix, it does not seem necessary to back-patch it:
> > the parent relation always has the same persistence as its indexes.
>
> There was an argument for doing it this way that only applies if this
> patch went in, but I can't remember now what it was.
>
> Anyway I pushed the patch after some slight additional changes.  Thanks!
>

Thanks!

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: WIP: multivariate statistics / proof of concept
Next
From: Simon Riggs
Date:
Subject: Re: Patch to support SEMI and ANTI join removal