Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED
Date
Msg-id 20141115042358.GT1791@alvin.alvh.no-ip.org
Whole thread Raw
In response to Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED  (Fabrízio de Royes Mello <fabriziomello@gmail.com>)
Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED  (Christian Ullrich <chris@chrullrich.net>)
List pgsql-hackers
Michael Paquier wrote:

> Btw, perhaps this diff should be pushed as a different patch as this is a
> rather different thing:
> -       if (heapRelation->rd_rel->relpersistence == RELPERSISTENCE_UNLOGGED
> &&
> +       if (indexRelation->rd_rel->relpersistence ==
> RELPERSISTENCE_UNLOGGED &&
>                 !smgrexists(indexRelation->rd_smgr, INIT_FORKNUM)
> As this is a correctness fix, it does not seem necessary to back-patch it:
> the parent relation always has the same persistence as its indexes.

There was an argument for doing it this way that only applies if this
patch went in, but I can't remember now what it was.

Anyway I pushed the patch after some slight additional changes.  Thanks!

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Useless dead struct in parse_func.h
Next
From: Alvaro Herrera
Date:
Subject: Re: New storage parameter pages_per_range not mentioned in CREATE INDEX doc