On Sun, Oct 5, 2014 at 9:52 AM, Marti Raudsepp <marti@juffo.org> wrote: > > > The version 5 (attached) contains all discussed until now. > > From documentation: > > CREATE INDEX ... [ IF NOT EXISTS name | name ] ON ... > > Maybe I'm just slow, but it took me a few minutes to understand what > this means. :) >
Well, I try to show that "IF NOT EXISTS" require the "name". Is this wrong?
Anyway I fixed that way:
CREATE INDEX ... [ IF NOT EXISTS [ name ] ] ON ...
Maybe is better than the last... what you think?
> I would add a human-language explanation to IF NOT EXISTS description: > Index name is required when IF NOT EXISTS is specified >
Ok.
> ---- > You have resurrected this bit again, which now conflicts with git master... > > - write_msg(NULL, "reading row-security enabled for table \"%s\"", > + write_msg(NULL, "reading row-security enabled for table \"%s\"\n", >
Ohh... sorry... again... my mistake :-( now all was fixed.
> ---- > n->concurrent = $4; > + n->if_not_exists = false; > n->idxname = $5; > > Minor stylistic thing: now that this is a constant, I would move it to > the end together with other constant assignments, and follow the > struct's field ordering (in both code paths): > > n->isconstraint = false; > n->deferrable = false; > n->initdeferred = false; > n->if_not_exists = false; >