Postgres Pro
Downloads
Home   >   mailing lists

Re: Sequence Access Method WIP - Mailing list pgsql-hackers

From Fabrízio de Royes Mello
Subject Re: Sequence Access Method WIP
Date
Msg-id CAFcNs+of-yp13AwXp7waP40O_9YFG8TqPLovKL-uVYkp+1jc3w@mail.gmail.com
Whole thread Raw
In response to Re: Sequence Access Method WIP  (Petr Jelinek <petr@2ndquadrant.com>)
Responses Re: Sequence Access Method WIP  (Petr Jelinek <petr@2ndquadrant.com>)
List pgsql-hackers
Tree view


On Thu, Mar 31, 2016 at 9:19 AM, Petr Jelinek <petr@2ndquadrant.com> wrote:
>
> Hi,
>
> new version attached that should fix the issue. It was alignment - honestly don't know what I was thinking using fixed alignment when the AMs can define their own type.
>

Yeah... now all works fine... I had a minor issue when apply to the current master but the attached fix it and I also added tab-complete support for CREATE SEQUENCE...USING and ALTER SEQUENCE...USING.

I ran all the regression tests and all passed.

I have just one question about de 0002 patch:
- There are some reason to not use TransactionId instead of uint32 in GaplessSequenceState struct?

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello
Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Updated backup APIs for non-exclusive backups
Next
From: Corey Huinker
Date:
Subject: Re: Choosing parallel_degree