Postgres Pro
Downloads
Home   >   mailing lists

Re: Add regression tests for DISCARD - Mailing list pgsql-hackers

From Fabrízio de Royes Mello
Subject Re: Add regression tests for DISCARD
Date
Msg-id CAFcNs+oV6_acgRpvT+cN2N+9me4ct+QC0pnREUTBxRP9UhcveA@mail.gmail.com
Whole thread Raw
In response to Re: Add regression tests for DISCARD  (Robins Tharakan <tharakan@gmail.com>)
List pgsql-hackers
Tree view
On Sun, Jul 7, 2013 at 12:49 AM, Robins Tharakan <tharakan@gmail.com> wrote:
Thanks Fabrizio.

Although parallel_schedule was a miss for this specific patch, however, I guess I seem to have missed out serial_schedule completely (in all patches) and then thanks for pointing this out. Subsequently Robert too noticed the miss at the serial_schedule end.

Please find attached a patch, updated towards serial_schedule / parallel_schedule as well as the role name change as per Robert's feedback on CREATE OPERATOR thread.


Ok.

Some basic checks on this patch:

- Removed unnecessary extra-lines: Yes
- Cleanly applies to Git-Head: Yes
- Documentation Updated: N/A
- Tests Updated: Yes
- All tests pass: Yes.
- Does it Work: Yes
- Do we want it?: Yes
- Is this a new feature: No
- Does it support pg_dump: No
- Does it follow coding guidelines: Yes
- Any visible issues: No
- Any corner cases missed out: No
- Performance tests required: No
- Any compiler warnings: No
- Are comments sufficient: Yes
- Others: N/A

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello

pgsql-hackers by date:

Previous
From: Jaime Casanova
Date:
Subject: Re: Differences in WHERE clause of SELECT
Next
From: Andrew Dunstan
Date:
Subject: Re: [PATCH] Remove useless USE_PGXS support in contrib