Re: Historic snapshot doesn't track txns committed in BUILDING_SNAPSHOT state - Mailing list pgsql-hackers

On Thu, Mar 27, 2025 at 2:47 PM cca5507 <cca5507@qq.com> wrote:
>
> Hi,
>
> According to the comment above DecodeTXNNeedSkip(), transactions committed before SNAPBUILD_CONSISTENT state won't be
decoded.It's important for initial table data synchronization because the table sync workers use the consistent
snapshotto copy data so transactions before SNAPBUILD_CONSISTENT are already included in the initial data. 
>
> This change may be redundant with SnapBuildXactNeedsSkip(), I add just for safe.
>
> --

I understand your explanation but was there a bug on HEAD that this is
solving? If so, can you write a test case to show this? This will make
it more convincing that this change as well is required. Your other
change has a test case to confirm, but this doesn't.

regards,
Ajin Cherian
Fujitsu Australia