Re: Historic snapshot doesn't track txns committed in BUILDING_SNAPSHOT state - Mailing list pgsql-hackers

From cca5507
Subject Re: Historic snapshot doesn't track txns committed in BUILDING_SNAPSHOT state
Date
Msg-id tencent_B54A1979BC9D8332BBADD092C2B8DA829407@qq.com
Whole thread Raw
In response to Re: Historic snapshot doesn't track txns committed in BUILDING_SNAPSHOT state  (Ajin Cherian <itsajin@gmail.com>)
Responses Re: Historic snapshot doesn't track txns committed in BUILDING_SNAPSHOT state
List pgsql-hackers
Hi,

According to the comment above DecodeTXNNeedSkip(), transactions committed before SNAPBUILD_CONSISTENT state won't be decoded. It's important for initial table data synchronization because the table sync workers use the consistent snapshot to copy data so transactions before SNAPBUILD_CONSISTENT are already included in the initial data.

This change may be redundant with SnapBuildXactNeedsSkip(), I add just for safe.

--
Regards,
ChangAo Chen

pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: support ALTER TABLE DROP EXPRESSION for virtual generated column
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.