Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool historyand related tests to remove dependency on React - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool historyand related tests to remove dependency on React
Date
Msg-id CAFOhELfXHo-YdOqnyUkX1Mi2EDObDi+yNhwwU36rDt6g-N_Pcw@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool historyand related tests to remove dependency on React  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool historyand related tests to remove dependency on React
List pgadmin-hackers
Tree view


On Thu, Mar 7, 2019 at 4:23 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks - committed. Oddly, having removed a bunch of files and 88 JS dependencies, the resulting Python package is actually slightly bigger!
And now I have conflicts in around 40 files. :)

On Thu, Mar 7, 2019 at 9:46 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to remove React dependency in pgAdmin.
The query history component is re-written using jQuery and vanilla JS. There is no change in look and feel. Test cases are modified accordingly. Perform a "yarn install" before bundling.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 v4.3 released
Next
From: Dave Page
Date:
Subject: Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool historyand related tests to remove dependency on React