Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool historyand related tests to remove dependency on React - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool historyand related tests to remove dependency on React
Date
Msg-id CA+OCxowX5uqy1kKc3B50H3e+4AkWcCWrQoQhfPieKE31arnVpA@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool history andrelated tests to remove dependency on React  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Responses Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool historyand related tests to remove dependency on React
List pgadmin-hackers
Tree view
Thanks - committed. Oddly, having removed a bunch of files and 88 JS dependencies, the resulting Python package is actually slightly bigger!

On Thu, Mar 7, 2019 at 9:46 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to remove React dependency in pgAdmin.
The query history component is re-written using jQuery and vanilla JS. There is no change in look and feel. Test cases are modified accordingly. Perform a "yarn install" before bundling.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Remove the large and unnecessary dependency onReact
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 v4.3 released