Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, andadd support procedure for PG v11 - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, andadd support procedure for PG v11
Date
Msg-id CAFOhELfWXEyeauH_SgVvWBEtKxTqRFyDCUY8Jvr7qnGUfN=F9A@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, andadd support procedure for PG v11  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, andadd support procedure for PG v11  (Victoria Henry <vhenry@pivotal.io>)
List pgadmin-hackers
Hi,

Please find the attached updated patch.

On Fri, Jun 8, 2018 at 2:21 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Jun 7, 2018 at 11:27 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please ignore my previous patch, find the attached updated one.

I found a couple of issues with this:

- Clicking the + button on the Parameters tab does nothing in either Create or Edit modes

Fixed 
- The debugger fails to start (though, perhaps that's because the plugin doesn't have Ashesh's latest patches in it).

FYI, I was trying to test the debugger with:

-- PROCEDURE: public.dummy_proc(integer)

-- DROP PROCEDURE public.dummy_proc(integer);

CREATE OR REPLACE  PROCEDURE public.dummy_proc(
id integer)
LANGUAGE 'plpgsql'

AS $BODY$BEGIN
  raise notice 'id is %', id;
END;$BODY$;

Fixed. Tested with the latest code of the plugin.
Thanks!

Thanks,
Khushboo 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: [pgadmin4][patch][GreenPlum] Display SQL for tables takes 15minutes to execute
Next
From: Khushboo Vashi
Date:
Subject: Re: [pgadmin4][Patch]: Test cases for the backup module