Re: [PgAdmin][RM4237]: User can not change value of Datetime pickercontrol using keyboard (Accessibility). - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [PgAdmin][RM4237]: User can not change value of Datetime pickercontrol using keyboard (Accessibility).
Date
Msg-id CAFOhELc8C2cxgYG7XdbGFHKFt-Y5HNv3WrzQmmh6EXQ99M2sLw@mail.gmail.com
Whole thread Raw
In response to Re: [PgAdmin][RM4237]: User can not change value of Datetime pickercontrol using keyboard (Accessibility).  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Hi Pradip,

Looks like you have repeated below code in if and else both the conditions.

let $el = this.$el.find('.datetimepicker-input');
let currdate = $el.data('datetimepicker').date().clone();

We can optimize this code by taking these both lines above if condition.

Thanks,
Khushboo

On Tue, Mar 10, 2020 at 1:24 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Tue, Mar 10, 2020 at 1:17 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Akshay,
I have already added the code to change the time. To select the time picker, the user needs to press 'Alt+T' (Option+T for mac)  and then Up/Down arrows to change the minutes and Alt + Up/Down to change the hours.

On Mon, Mar 9, 2020 at 11:09 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Pradip

I have tested the patch. I am able to navigate the dates using the keyboard, but not able to select the year/month and time. Can you please work on it and send the patch again.

On Sat, Mar 7, 2020 at 7:00 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Attached is a patch to change the Datetime picker value using a keyboard.


--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [PgAdmin][RM4237]: User can not change value of Datetime pickercontrol using keyboard (Accessibility).
Next
From: Ganesh Jaybhay
Date:
Subject: Re: [pgAdmin][RM4764][Accessibility] Allow screen-reader to readrelationship attributes in nested elements