Re: generate syscache info automatically - Mailing list pgsql-hackers

From John Naylor
Subject Re: generate syscache info automatically
Date
Msg-id CAFBsxsHJF5RVvS_3JkAssOo-hOsz74cMG-A2BFm9O5x3bWxS+g@mail.gmail.com
Whole thread Raw
In response to Re: generate syscache info automatically  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: generate syscache info automatically
List pgsql-hackers

On Thu, Aug 31, 2023 at 6:23 PM Peter Eisentraut <peter@eisentraut.org> wrote:

> Attached is an updated patch set.
>
> One win here is that the ObjectProperty lookup now uses a hash function
> instead of a linear search.  So hopefully the performance is better (to
> be confirmed) and it could now be used for things like [0].

+ # XXX This one neither, but if I add it to @skip, PerfectHash will fail. (???)
+ #FIXME: AttributeRelationId

I took a quick look at this, and attached is the least invasive way to get it working for now, which is to bump the table size slightly. The comment says doing this isn't reliable, but it happens to work in this case. Playing around with the functions is hit-or-miss, and when that fails, somehow the larger table saves the day.

--
John Naylor
EDB: http://www.enterprisedb.com
Attachment

pgsql-hackers by date:

Previous
From: Jim Jones
Date:
Subject: Re: Show inline comments from pg_hba lines in the pg_hba_file_rules view
Next
From: Alvaro Herrera
Date:
Subject: Re: Assert failure in ATPrepAddPrimaryKey