On Thu, Aug 10, 2023 at 5:54 PM Michael Paquier <
michael@paquier.xyz> wrote:
>
> On Thu, Aug 10, 2023 at 03:56:37PM +0530, Amit Kapila wrote:
> > In MSVC build, on doing: perl
mkvcbuild.pl after this commit, I am
> > facing the below error:
> > Generating configuration headers...
> > undefined symbol: USE_LOONGARCH_CRC32C at src/include/pg_config.h line
> > 718 at ../postgresql/src/tools/msvc/Mkvcbuild.pm line 872.
> >
> > Am I missing something or did the commit miss something?
>
> Yes, the commit has missed the addition of USE_LOONGARCH_CRC32C in
> Solution.pm. If you want to be consistent with
pg_config.h.in, you
> could add it just after USE_LLVM, for instance.
Oops, fixing now...
--
John Naylor
EDB:
http://www.enterprisedb.com