Re: [PATCH] Add loongarch native checksum implementation. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Add loongarch native checksum implementation.
Date
Msg-id ZNTB8S4dwOsWITuk@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Add loongarch native checksum implementation.  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [PATCH] Add loongarch native checksum implementation.
List pgsql-hackers
On Thu, Aug 10, 2023 at 03:56:37PM +0530, Amit Kapila wrote:
> In MSVC build, on doing: perl mkvcbuild.pl after this commit, I am
> facing the below error:
> Generating configuration headers...
> undefined symbol: USE_LOONGARCH_CRC32C at src/include/pg_config.h line
> 718 at ../postgresql/src/tools/msvc/Mkvcbuild.pm line 872.
>
> Am I missing something or did the commit miss something?

Yes, the commit has missed the addition of USE_LOONGARCH_CRC32C in
Solution.pm.  If you want to be consistent with pg_config.h.in, you
could add it just after USE_LLVM, for instance.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Add assertion on held AddinShmemInitLock in GetNamedLWLockTranche()
Next
From: Thomas Munro
Date:
Subject: Re: A failure in 031_recovery_conflict.pl on Debian/s390x