Re: A qsort template - Mailing list pgsql-hackers

From John Naylor
Subject Re: A qsort template
Date
Msg-id CAFBsxsFRYNL-XgXqY0mddxCGSAepE=zY3VT9vggFANdZwQT4pQ@mail.gmail.com
Whole thread Raw
In response to Re: A qsort template  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: A qsort template  (John Naylor <john.naylor@enterprisedb.com>)
List pgsql-hackers
On Fri, May 20, 2022 at 5:43 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Peter Geoghegan <pg@bowt.ie> writes:
> > On Thu, May 19, 2022 at 1:12 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> >> Should these debug lines be removed ?
> >>
> >> elog(DEBUG1, "qsort_tuple");
>
> > I agree -- DEBUG1 seems too chatty for something like this. DEBUG2
> > would be more appropriate IMV. Though I don't feel very strongly about
> > it.
>
> Given the lack of context identification, I'd put the usefulness of
> these in production at close to zero.  +1 for removing them
> altogether, or failing that, downgrade to DEBUG5 or so.

I agree this is only useful in development. Removal sounds fine to me,
so I'll do that soon.

-- 
John Naylor
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Ian Lawrence Barwick
Date:
Subject: docs: mention "pg_read_all_stats" in "track_activities" description
Next
From: Christoph Berg
Date:
Subject: Re: 15beta1 crash on mips64el in pg_regress/triggers