Re: pgsql: Build all Flex files standalone - Mailing list pgsql-committers

From John Naylor
Subject Re: pgsql: Build all Flex files standalone
Date
Msg-id CAFBsxsFQXQuK3uhFNBxbTSTM2s7jgFKQyvap1TdQ_d85+puuCg@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Build all Flex files standalone  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Build all Flex files standalone  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
On Sun, Sep 4, 2022 at 8:34 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
> On 2022-09-04 Su 02:19, John Naylor wrote:
> > Crake fails with
> >
> > headerscheck:
> > Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2:
> > Sep 04 01:56:01
> > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
> > fatal error: jsonpath_gram.h: No such file or directory
> > Sep 04 01:56:01    26 | #include "jsonpath_gram.h"
> > Sep 04 01:56:01       |          ^~~~~~~~~~~~~~~~~
> > Sep 04 01:56:01 compilation terminated.
> > Sep 04 01:56:14 make: *** [GNUmakefile:138: headerscheck] Error 1
> > cpluspluscheck:
> > Sep 04 01:57:19 In file included from /tmp/cpluspluscheck.HhRV5k/test.cpp:3:
> > Sep 04 01:57:19
> > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
> > fatal error: jsonpath_gram.h: No such file or directory
> > Sep 04 01:57:19    26 | #include "jsonpath_gram.h"
> > Sep 04 01:57:19       |          ^~~~~~~~~~~~~~~~~
> >
> > I don't get the same in an already-built tree. I also don't see an
> > exception for gramparse.h, which I imagine would have the same issue?
>
>
>
> Probably happens because crake does vpath builds. I think you're going
> to have to set up EXTRAINCLUDES for it - see near the bottom of the
> headerscheck script. Possibly something like
>
>
>     src/backend/utils/adt/*)
>
>     EXTRAINCLUDES="-I $builddir/src/backend/utils/adt" ;;

I just tried a vpath build and the failing check doesn't reproduce for
me there. Any ideas?

--
John Naylor
EDB: http://www.enterprisedb.com



pgsql-committers by date:

Previous
From: John Naylor
Date:
Subject: pgsql: Add missing exceptions to cpluspluscheck
Next
From: David Rowley
Date:
Subject: pgsql: Remove buggy and dead code from CreateTriggerFiringOn