Re: Typo in pg_db_role_setting.h - Mailing list pgsql-hackers

From John Naylor
Subject Re: Typo in pg_db_role_setting.h
Date
Msg-id CAFBsxsETpmZqWjLJw3gKjNg-dHUuR-+UnfoaBNhL4MoHJP1G3w@mail.gmail.com
Whole thread Raw
In response to Typo in pg_db_role_setting.h  (Japin Li <japinli@hotmail.com>)
Responses Re: Typo in pg_db_role_setting.h
Re: Typo in pg_db_role_setting.h
List pgsql-hackers

On Mon, Aug 1, 2022 at 4:18 PM Japin Li <japinli@hotmail.com> wrote:
>
>
> Hi, hackers
>
> I think there is a typo in pg_db_role_setting.h, should we fix it?
>
> diff --git a/src/include/catalog/pg_db_role_setting.h b/src/include/catalog/pg_db_role_setting.h
> index 45d478e9e7..f92e867df4 100644
>  /*
> - * prototypes for functions in pg_db_role_setting.h
> + * prototypes for functions in pg_db_role_setting.c
>   */

You are correct, but I wonder if it'd be better to just drop the comment entirely. I checked a couple other random headers with function declarations and they didn't have such a comment, and it's kind of obvious what they're for.

--
John Naylor
EDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: NAMEDATALEN increase because of non-latin languages
Next
From: "Euler Taveira"
Date:
Subject: Re: logical replication restrictions