On Tue, Oct 25, 2022 at 9:48 AM Richard Guo <
guofenglinux@gmail.com> wrote:
>
>
> On Tue, Oct 25, 2022 at 10:05 AM John Naylor <
john.naylor@enterprisedb.com> wrote:
>>
>> It's perfectly clear and simple now, even if it doesn't win at "code golf".
>
>
> Agree with your point. Do you think we can further make the one-line
> function a macro or an inline function in the .h file? I think this
> function is called quite frequently during planning, so maybe doing that
> would bring a little bit of efficiency.
My point was misunderstood, which is: I don't think we need to do anything at all here if the goal was purely about aesthetics.
If the goal has now changed to efficiency, I have no opinion about that yet since no evidence has been presented.
--
John Naylor
EDB:
http://www.enterprisedb.com
