BufmgrCommit no-op since 2008, remaining uses? - Mailing list pgsql-hackers

From Matthias van de Meent
Subject BufmgrCommit no-op since 2008, remaining uses?
Date
Msg-id CAEze2Wi1=tLKbxZnXzcD+8fYKyKqBtivVakLQC_mYBsP4Y8qVA@mail.gmail.com
Whole thread Raw
Responses Re: BufmgrCommit no-op since 2008, remaining uses?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

Whilst reading up on the transaction commit code, I noticed the following lines:

  /* Tell bufmgr and smgr to prepare for commit */
  BufmgrCommit();

BufmgrCommit does exactly nothing; it is an empty function and has
been since commit 33960006 in late 2008 when it stopped calling
smgrcommit().

All two usages of the function (in our code base) seem to be in
xact.c. Are we maintaining it for potential future use, or can the
function be removed?

Kind regards,

Matthias van de Meent



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Initial Schema Sync for Logical Replication
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Allow Postgres to pick an unused port to listen