Re: [PATCH] Allow Postgres to pick an unused port to listen - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Allow Postgres to pick an unused port to listen
Date
Msg-id 3803291.1680090943@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] Allow Postgres to pick an unused port to listen  (Yurii Rashkovskii <yrashk@gmail.com>)
Responses Re: [PATCH] Allow Postgres to pick an unused port to listen  (Yurii Rashkovskii <yrashk@gmail.com>)
Re: [PATCH] Allow Postgres to pick an unused port to listen  (Yurii Rashkovskii <yrashk@gmail.com>)
Re: [PATCH] Allow Postgres to pick an unused port to listen  (Andrew Dunstan <andrew@dunslane.net>)
Re: [PATCH] Allow Postgres to pick an unused port to listen  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
Yurii Rashkovskii <yrashk@gmail.com> writes:
> I would like to suggest a patch against master (although it may be worth
> backporting it) that makes it possible to listen on any unused port.

I think this is a bad idea, mainly because this:

> Instead, with this patch, one can specify `port` as `0` (the "wildcard"
> port) and retrieve the assigned port from postmaster.pid

is a horrid way to find out what was picked, and yet there could
be no other.

Our existing design for this sort of thing is to let the testing
framework choose the port, and I don't really see what's wrong
with that approach.  Yes, I know it's theoretically subject to
race conditions, but that hasn't seemed to be a problem in
practice.  It's especially not a problem given that modern
testing practice tends to not open any TCP port at all, just
a Unix socket in a test-private directory, so that port
conflicts are a non-issue.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Matthias van de Meent
Date:
Subject: BufmgrCommit no-op since 2008, remaining uses?
Next
From: Tom Lane
Date:
Subject: Re: BufmgrCommit no-op since 2008, remaining uses?