Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c)
Date
Msg-id CAEudQArroryU3bAnqSztZhGDovrESdhKPDquhBq23x-Fv=khMg@mail.gmail.com
Whole thread Raw
In response to Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c)  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c)  (Greg Nancarrow <gregn4422@gmail.com>)
List pgsql-hackers
Em ter., 17 de ago. de 2021 às 05:04, Michael Paquier <michael@paquier.xyz> escreveu:
On Fri, Jul 02, 2021 at 06:22:56PM -0300, Ranier Vilela wrote:
> Em qui., 1 de jul. de 2021 às 17:20, Mahendra Singh Thalor <
> mahi6run@gmail.com> escreveu:
>> Please can we try to hit this rare condition by any test case. If you have
>> any test cases, please share.

Yeah, this needs to be proved.
Due to the absolute lack of reports, I believe that this particular case never happened.

  Are you sure that this change is
actually right?
Yes, have.

  The bottom of FreePageManagerPutInternal() has
assumptions that a page may not be found during a btree search, with
an index value used.
Assert assumptions are for Debug.
If that's conditions happen, all *result.index* touches are garbage.

regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: "tanghy.fnst@fujitsu.com"
Date:
Subject: RE: [PATCH]Remove obsolete macro CHECKFLOATVAL in btree_gist
Next
From: Andres Freund
Date:
Subject: Re: ALTER TYPE vs extension membership (was Re: BUG #17144: Upgrade from v13 to v14 with the cube extension failed)