Re: Speedup usages of pg_*toa() functions - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Speedup usages of pg_*toa() functions
Date
Msg-id CAEudQArZXgrFShBEd49r7kxHsFz1J7v9AKhZ2HTHeZ5WOjRryg@mail.gmail.com
Whole thread Raw
In response to Re: Speedup usages of pg_*toa() functions  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
Responses Re: Speedup usages of pg_*toa() functions  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
List pgsql-hackers
Em ter., 9 de jun. de 2020 às 17:42, Andrew Gierth <andrew@tao11.riddles.org.uk> escreveu:
>>>>> "Ranier" == Ranier Vilela <ranier.vf@gmail.com> writes:

 Ranier> So I would change, just the initialization (var uvalue), even though it is
 Ranier> irrelevant.

 Ranier> int
 Ranier> pg_lltoa(int64 value, char *a)
 Ranier> {
 Ranier> int len = 0;
 Ranier> uint64 uvalue;

 Ranier> if (value < 0)
 Ranier> {
 Ranier> uvalue = (uint64) 0 - uvalue;

Use of uninitialized variable.
Sorry, my mistake.

uvalue = (uint64) 0 - value;

regards,
Ranier Vilela
 

--
Andrew (irc:RhodiumToad)

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Why is pq_begintypsend so slow?
Next
From: Thomas Munro
Date:
Subject: Re: Fast DSM segments