Postgres Pro
Downloads
Home   >   mailing lists

Re: PG compilation error with Visual Studio 2015/2017/2019 - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: PG compilation error with Visual Studio 2015/2017/2019
Date
Msg-id CAEudQArZHcK_dR4UiQyCqVi11U4c-bq=xqD5k-FNe7zHVnSVig@mail.gmail.com
Whole thread Raw
In response to Re: PG compilation error with Visual Studio 2015/2017/2019  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: PG compilation error with Visual Studio 2015/2017/2019
List pgsql-hackers
Tree view
Em qua., 22 de abr. de 2020 às 08:43, Amit Kapila <amit.kapila16@gmail.com> escreveu:
On Tue, Apr 21, 2020 at 5:32 PM Juan José Santamaría Flecha
<juanjo.santamaria@gmail.com> wrote:
>
> On Tue, Apr 21, 2020 at 12:41 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>>
6. I have additionally done some cosmetic changes in the attached patch.
I made some style changes too.
 
1. Change:
 strcpy(iso_lc_messages, "C");
to
iso_lc_messages[0] = 'C';
iso_lc_messages[1] = '\0';
2. Remove vars hyphen and underscore;
3. Avoid call second wcsrchr, if hyphen is not found.

If it's not too much perfectionism.
 
regards,
Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: design for parallel backup
Next
From: Jesse Zhang
Date:
Subject: Header / Trailer Comment Typos for M4 macros