Re: postgres_fdw hint messages - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: postgres_fdw hint messages
Date
Msg-id CAEudQAq3p=MNtfyUyU3Jp-w0brPsSKJOhuOAOkX5FUOOaitj7Q@mail.gmail.com
Whole thread Raw
In response to re: postgres_fdw hint messages  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
Em qui., 25 de ago. de 2022 às 14:31, Ranier Vilela <ranier.vf@gmail.com> escreveu:

>The postgres_fdw tests contain this (as amended by patch 0001):

>ALTER SERVER loopback_nopw OPTIONS (ADD password 'dummypw');
>ERROR: invalid option "password"
>HINT: Valid options in this context are: service, passfile,
>channel_binding, connect_timeout, dbname, host, hostaddr, port, options,
>application_name, keepalives, keepalives_idle, keepalives_interval,
>keepalives_count, tcp_user_timeout, sslmode, sslcompression, sslcert,
>sslkey, sslrootcert, sslcrl, sslcrldir, sslsni, requirepeer,
>ssl_min_protocol_version, ssl_max_protocol_version, gssencmode,
>krbsrvname, gsslib, target_session_attrs, use_remote_estimate,
>fdw_startup_cost, fdw_tuple_cost, extensions, updatable, truncatable,
>fetch_size, batch_size, async_capable, parallel_commit, keep_connections

>This annoys developers who are working on libpq connection options,
>because any option added, removed, or changed causes this test to need
>to be updated.

>It's also questionable how useful this hint is in its current form,
>considering how long it is and that the options are in an
>implementation-dependent order.

>Possible changes:

>- Hide the hint from this particular test (done in the attached patches).+1

I vote for this option.
Less work for future developers changes, I think worth the effort.

Anyway, in alphabetical order, it's a lot easier for users to read.

Patch attached.
Little tweak in the comments.

regards,
Ranier Vilela

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: V14 and later build the backend with -lpthread
Next
From: Pavel Stehule
Date:
Subject: Re: Schema variables - new implementation for Postgres 15