Postgres Pro
Downloads
Home   >   mailing lists

Re: Signed vs. Unsigned (some) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Signed vs. Unsigned (some)
Date
Msg-id CAEudQApnxSWe1m_eLxSzYO+Ooe78SgeNe8P8d-jUFwqr_c=VGQ@mail.gmail.com
Whole thread Raw
In response to Signed vs. Unsigned (some)  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
Tree view
Em sex., 11 de jun. de 2021 às 23:05, Ranier Vilela <ranier.vf@gmail.com> escreveu:
Hi,

Removing legitimate warnings can it be worth it?

-1 CAST can be wrong, when there is an invalid value defined (InvalidBucket, InvalidBlockNumber).
I think depending on the compiler -1 CAST may be different from InvalidBucket or InvalidBlockNumber.

pg_rewind is one special case.
All cases of XLogSegNo (uint64) initialization are zero, but in pg_rewind was used -1?
I did not find it InvalidXLogSegNo!
Not tested.

Trivial patch attached.
After a long time, finally a small part is accepted and fixed.
https://github.com/postgres/postgres/commit/302612a6c74fb16f26d094ff47e9c59cf412740c

regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Mark all GUC variable as PGDLLIMPORT
Next
From: Andres Freund
Date:
Subject: Re: Adding CI to our tree