Home > mailing lists

Signed vs. Unsigned (some) - Mailing list pgsql-hackers

From	Ranier Vilela
Subject	Signed vs. Unsigned (some)
Date	June 12, 2021 05:05:29
Msg-id	CAEudQAp=ZwKjrP4L+CzqV7SmWiaQidPPRqj4tqdjDG4KBx5yrg@mail.gmail.com Whole thread Raw
Responses	Re: Signed vs. Unsigned (some) Re: Signed vs. Unsigned (some)
List	pgsql-hackers

Hi,

Removing legitimate warnings can it be worth it?

-1 CAST can be wrong, when there is an invalid value defined (InvalidBucket, InvalidBlockNumber).

I think depending on the compiler -1 CAST may be different from InvalidBucket or InvalidBlockNumber.

pg_rewind is one special case.

All cases of XLogSegNo (uint64) initialization are zero, but in pg_rewind was used -1?

I did not find it InvalidXLogSegNo!

Not tested.

Trivial patch attached.

best regards,

Ranier Vilela

From: Andres Freund
Date: 12 June 2021, 04:44:34
Subject: ProcArrayStruct->pgprocnos vs ->maxProcs vs PGPROC ordering

From: Justin Pryzby
Date: 12 June 2021, 05:33:25
Subject: pg_filenode_relation(0,0) elog