Re: list_free in addRangeTableEntryForJoin - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: list_free in addRangeTableEntryForJoin
Date
Msg-id CAEudQApdbWD2vwXG1hZUwGbOd6TLp3eHi48LRYhjsE6Fzv0Tnw@mail.gmail.com
Whole thread Raw
In response to Re: list_free in addRangeTableEntryForJoin  (Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>)
List pgsql-hackers
Em seg., 10 de jun. de 2024 às 09:11, Ilia Evdokimov <ilya.evdokimov@tantorlabs.com> escreveu:
 >But callers of addRangeTableEntryForJoin(), expects to handle a list
or NIL, if we free the memory
I've thoroughly reviewed all callers of the
`addRangeTableEntryForJoin()` function and confirmed that the list is
not used after this function is called. Since
`addRangeTableEntryForJoin()` is the last function to use this list, it
would be more efficient to free the `List` at the point of its declaration.

I'll attach new patch where I free the lists.
Seems like a better style.

Now you need to analyze whether the memory in question is not managed by a Context and released in a block, 
which would make this release useless.

best regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Ilia Evdokimov
Date:
Subject: Re: list_free in addRangeTableEntryForJoin
Next
From: James Coleman
Date:
Subject: Re: Fix grammar oddities in comments