Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Use optimized single-datum tuplesort in ExecSort - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: [PATCH] Use optimized single-datum tuplesort in ExecSort
Date
Msg-id CAEudQApYCj7sCsFVa_knbDt+uQ6q9HRJT1RGwRROsDYXvuvOvA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Use optimized single-datum tuplesort in ExecSort  (Ronan Dunklau <ronan.dunklau@aiven.io>)
Responses Re: [PATCH] Use optimized single-datum tuplesort in ExecSort  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
Tree view
Em ter., 13 de jul. de 2021 às 04:19, Ronan Dunklau <ronan.dunklau@aiven.io> escreveu:
> I've now pushed that bug fix so it's fine to remove the change to

 
I would be
surprised the check adds that much to the whole execution though.
I think this branch is a misprediction.
In most cases is it not datumSort?
That's why I would like to use unlikely.

IMO all the tests should all be to verify past behavior first.

regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: psql \copy from sends a lot of packets
Next
From: Amit Langote
Date:
Subject: Re: a misbehavior of partition row movement (?)