Re: Fix out-of-bounds in the function GetCommandTagName - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Fix out-of-bounds in the function GetCommandTagName
Date
Msg-id CAEudQApQXCZ_d=viNawsB-x_5dNiaES1s4w=kWgtOvROBFjH7g@mail.gmail.com
Whole thread Raw
In response to Re: Fix out-of-bounds in the function GetCommandTagName  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Em seg., 13 de mai. de 2024 às 14:38, Tom Lane <tgl@sss.pgh.pa.us> escreveu:
David Rowley <dgrowleyml@gmail.com> writes:
> I've added a CF entry under your name for this:
> https://commitfest.postgresql.org/48/4927/

> If it was code new to PG17 I'd be inclined to go ahead with it now,
> but it does not seem to align with making the release mode stable.
> I'd bet others will feel differently about that.  Delaying seems a
> better default choice at least.

The security team's Coverity instance has started to show this
complaint now too.  So I'm going to go ahead and push this change
in HEAD.  It's probably unwise to change it in stable branches,
since there's at least a small chance some external code is using
COMMAND_TAG_NEXTTAG for the same purpose tag_behavior[] does.
But we aren't anywhere near declaring v17's API stable, so
I'd rather fix the issue than dismiss it in HEAD.
Thanks for the commit, Tom.

best regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Antonin Houska
Date:
Subject: Re: UniqueKey v2
Next
From: Ranier Vilela
Date:
Subject: Re: Fix resource leak (src/backend/libpq/be-secure-common.c)