Re: Fix out-of-bounds in the function GetCommandTagName - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fix out-of-bounds in the function GetCommandTagName
Date
Msg-id 767885.1715621896@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fix out-of-bounds in the function GetCommandTagName  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Fix out-of-bounds in the function GetCommandTagName
List pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> I've added a CF entry under your name for this:
> https://commitfest.postgresql.org/48/4927/

> If it was code new to PG17 I'd be inclined to go ahead with it now,
> but it does not seem to align with making the release mode stable.
> I'd bet others will feel differently about that.  Delaying seems a
> better default choice at least.

The security team's Coverity instance has started to show this
complaint now too.  So I'm going to go ahead and push this change
in HEAD.  It's probably unwise to change it in stable branches,
since there's at least a small chance some external code is using
COMMAND_TAG_NEXTTAG for the same purpose tag_behavior[] does.
But we aren't anywhere near declaring v17's API stable, so
I'd rather fix the issue than dismiss it in HEAD.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Allowing additional commas between columns, and at the end of the SELECT clause
Next
From: Jelte Fennema-Nio
Date:
Subject: Re: Direct SSL connection with ALPN and HBA rules