Re: Memory leak fix in psql - Mailing list pgsql-hackers

From Junwang Zhao
Subject Re: Memory leak fix in psql
Date
Msg-id CAEG8a3L5wwEfTJv9t0VMXEuGggOpg4pbTyua3mz2eRdDf5wtnw@mail.gmail.com
Whole thread Raw
In response to Re: Memory leak fix in psql  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Memory leak fix in psql
List pgsql-hackers
-1

Though the patch looks good, I myself think the patch should be edited
and submitted by Tang
It's easy to attach a fixed patch based on the comments of the thread,
but coins should be
given to Tang since he is the first one to find the mem leak.

No offense, but that's what I think how open source works ;)

On Wed, Jul 20, 2022 at 11:51 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Jul 20, 2022 at 03:14:35AM +0000, tanghy.fnst@fujitsu.com wrote:
> > Your fix LGTM so please allow me to merge it in the attached patch.
> > Based on your rebased version, now this new patch version is V3.
>
> What about the argument of upthread where we could use a goto in
> functions where there are multiple pattern validation checks?  Per se
> v4 attached.
> --
> Michael



-- 
Regards
Junwang Zhao



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Next
From: Tom Lane
Date:
Subject: Re: Remove fls(), use pg_bitutils.h facilities instead?