Re: Two pg_rewind patches (auto generate recovery conf and ensureclean shutdown) - Mailing list pgsql-hackers

From Paul Guo
Subject Re: Two pg_rewind patches (auto generate recovery conf and ensureclean shutdown)
Date
Msg-id CAEET0ZGeJg_aRxPHv=i5jd2cvRV1oN5qCX=gXp9tUaA5M2fLGg@mail.gmail.com
Whole thread Raw
In response to Re: Two pg_rewind patches (auto generate recovery conf and ensureclean shutdown)  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers


On Tue, Jul 2, 2019 at 12:35 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
On 2019-Apr-19, Paul Guo wrote:

> The below patch runs single mode Postgres if needed to make sure the target
> is cleanly shutdown. A new option is added (off by default).
> v2-0001-Ensure-target-clean-shutdown-at-beginning-of-pg_r.patch

Why do we need an option for this?  Is there a reason not to do this
unconditionally?

There is concern about this (see previous emails in this thread). On greenplum (MPP DB based on Postgres),
we unconditionally do this. I'm not sure about usually how Postgres users do this when there is an unclean shutdown,
but providing an option seem to be safer to avoid breaking existing script/service whatever. If many people
think this option is unnecessary, I'm fine to remove the option and keep the code logic.
 
 

pgsql-hackers by date:

Previous
From: Paul Guo
Date:
Subject: Re: Two pg_rewind patches (auto generate recovery conf and ensureclean shutdown)
Next
From: Michael Paquier
Date:
Subject: Re: C testing for Postgres