Postgres Pro
Downloads
Home   >   mailing lists

Re: Two pg_rewind patches (auto generate recovery conf and ensureclean shutdown) - Mailing list pgsql-hackers

From Paul Guo
Subject Re: Two pg_rewind patches (auto generate recovery conf and ensureclean shutdown)
Date
Msg-id CAEET0ZF+Pjm7t9vafnpSvh+g_Jeun7UNs4rHrUxV2d9bFPzttQ@mail.gmail.com
Whole thread Raw
In response to Re: Two pg_rewind patches (auto generate recovery conf and ensureclean shutdown)  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Two pg_rewind patches (auto generate recovery conf and ensureclean shutdown)  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view


On Wed, Jul 10, 2019 at 3:28 PM Michael Paquier <michael@paquier.xyz> wrote:
On Tue, Jul 09, 2019 at 10:48:49PM +0800, Paul Guo wrote:
> Yes, the patches changed Makefile so that pg_rewind and pg_basebackup could
> use some common code, but for Windows build, I'm not sure where are those
> window build files. Does anyone know about that? Thanks.

The VS scripts are located in src/tools/msvc/.  You will likely need
to tweak things like $frontend_extraincludes or variables in the same
area for this patch (please see Mkvcbuild.pm).

Thanks. Both Mkvcbuild.pm and pg_rewind/Makefile are modified to make Windows build pass in a
local environment (Hopefully this passes the CI testing), also now pg_rewind/Makefile does not
create soft link for backup_common.h anymore. Instead -I is used to specify the header directory.

I also noticed that doc change is needed so modified documents for the two new options accordingly.
Please see the attached new patches.
Attachment

pgsql-hackers by date:

Previous
From: Konstantin Knizhnik
Date:
Subject: Re: Built-in connection pooler
Next
From: Daniel Gustafsson
Date:
Subject: Re: Option to dump foreign data in pg_dump