Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] WAL Consistency checking for hash indexes - Mailing list pgsql-hackers

From Ashutosh Sharma
Subject Re: [HACKERS] WAL Consistency checking for hash indexes
Date
Msg-id CAE9k0PmiO=1UTJCEL_FKgRsRJEkGmPxC5S7V2SYVhBC0Vyi2hw@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] WAL Consistency checking for hash indexes  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [HACKERS] WAL Consistency checking for hash indexes  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Tree view 
On Fri, Mar 17, 2017 at 9:03 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Thu, Mar 16, 2017 at 1:15 PM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
>> Hi,
>>
>> Attached is the patch that allows WAL consistency tool to mask
>> 'LH_PAGE_HAS_DEAD_TUPLES' flag in hash index. The flag got added as a
>> part of 'Microvacuum support for Hash index' patch . I have already
>> tested it using Kuntal's WAL consistency tool and it works fine.
>>
>
> + * unlogged. So, mask it. See _hash_kill_items(), MarkBufferDirtyHint()
> + * for
> details.
> + */
>
> I think in above comment, a reference to _hash_kill_items is
> sufficient.  Other than that patch looks okay.

Okay, I have removed the reference to MarkBufferDirtyHint() from above
comment. Attached is the v2 version of patch.

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachment

pgsql-hackers by date:

Previous
From: Ashutosh Sharma
Date:
Subject: Re: [HACKERS] Microvacuum support for Hash Index
Next
From: Nikhil Sontakke
Date:
Subject: Re: [HACKERS] Speedup twophase transactions