Postgres Pro
Downloads
Home   >   mailing lists

[pgadmin-hackers][patch] Raise InternalServerError while retrievingtable DDL - Mailing list pgadmin-hackers

From Joao Pedro De Almeida Pereira
Subject [pgadmin-hackers][patch] Raise InternalServerError while retrievingtable DDL
Date
Msg-id CAE+jjan4MxTxtKTOcmFJFavZbJKB+S=4NwkHipPmyz8V=_MS7Q@mail.gmail.com
Whole thread Raw
Responses Re: [patch] Raise InternalServerError whileretrieving table DDL
List pgadmin-hackers
Tree view
Hi Hackers,

While doing the DDL patch we found out that the code was not working properly when errors happened during SQL execution:

One example of this can be found in the file: 

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py

The function '_formatter' that returns internal_server_error when an error occur executing SQL
Nevertheless the 'sql' function uses the output of '_formatter' during the execution without checking it.

To solve this issue we raise an InternalServerError exception that we catch in the 'sql' function instead of returning an error message.


Thanks
Joao & Sarah
Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgadmin-hackers] Re-vamping the history tab
Next
From: Joao Pedro De Almeida Pereira
Date:
Subject: Re: [pgadmin-hackers][patch] Move to Alembic migration system