Postgres Pro
Downloads
Home   >   mailing lists

Re: [patch] Raise InternalServerError whileretrieving table DDL - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [patch] Raise InternalServerError whileretrieving table DDL
Date
Msg-id CA+OCxoz_a-m2SFMnH8H8TuhV3SwJvB0v-PTozH3twEQbARhvvA@mail.gmail.com
Whole thread Raw
In response to [pgadmin-hackers][patch] Raise InternalServerError while retrievingtable DDL  (Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io>)
Responses Re: [patch] Raise InternalServerError whileretrieving table DDL  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
List pgadmin-hackers
Tree view 
Ashesh, can you review/commit this please?

On Thu, Mar 23, 2017 at 3:49 PM, Joao Pedro De Almeida Pereira
<jdealmeidapereira@pivotal.io> wrote:
> Hi Hackers,
>
> While doing the DDL patch we found out that the code was not working
> properly when errors happened during SQL execution:
>
> One example of this can be found in the file:
>
> web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py
>
> The function '_formatter' that returns internal_server_error when an error
> occur executing SQL
> Nevertheless the 'sql' function uses the output of '_formatter' during the
> execution without checking it.
>
> To solve this issue we raise an InternalServerError exception that we catch
> in the 'sql' function instead of returning an error message.
>
>
> Thanks
> Joao & Sarah
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move languageselection to Preferences.
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Update translation docs for client side JStranslatio