Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger - Mailing list pgadmin-hackers

From Joao De Almeida Pereira
Subject Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger
Date
Msg-id CAE+jjakNUTfk3JmTJAae0nqk_Aq6MUgKo5hq4vTcF1ZfNM3zHw@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hello Murtuza,
After some review of the code we do have some questions:
 - Do we really need to have the shortcuts in the backend?(I already asked this in Khushboo's patch)
 - Do we need to have keyAction function(in direct.js) inside this Javascript file or can we extract that an create some tests around it?
 - Were there any tests created for these new shortcuts?

Thanks
Joao

On Thu, Feb 8, 2018 at 6:33 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to make shortcut configurable in debugger module.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Joao De Almeida Pereira
Date:
Subject: Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to allcommonly used menu options in the main window.
Next
From: Joao De Almeida Pereira
Date:
Subject: Re: [pgadmin4] Hide tabs in create table