Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes inServer dialog - Mailing list pgadmin-hackers

From Joao De Almeida Pereira
Subject Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes inServer dialog
Date
Msg-id CAE+jja=MZXA6E=O_2D0-n9p=1nmeJneWQJL_+XUCr2Hs4V1BFw@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes inServer dialog  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
List pgadmin-hackers
Tree view

Hi Murtuza,

We are having a hard time understanding the logic on the change.

If tunnel_authentication is not on the model and the tunnel_identify_file is present, we change the tunnel_identify_file in the model to null? Is this what you mean?

Thanks
Victoria && Joao

​

On Wed, May 30, 2018 at 9:27 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA minor patch to fix the issue when you change any field in server dialog 'tunnel_identity_file' model value get included unnecessarily in the update request.

eg: Change the server name and click on Save button, Check the request payload in network console.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Fix syntax
Next
From: Joao De Almeida Pereira
Date:
Subject: Re: pgAdmin 4 commit: Disable emojis in Yarn output.