Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence - Mailing list pgadmin-hackers

From Joao De Almeida Pereira
Subject Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence
Date
Msg-id CAE+jja=7RNmf5yvSNnfkJ602PX-pte6NOHYBBC65H_Mc+XapRw@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][RM#3014] Fix validation issues while creating new sequence  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence  (Dave Page <dpage@pgadmin.org>)
Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Murtuza,
Looks good. 
Was there any reason for the change in position of the if statements in the sql file. Makes the output more readable?
Looks like we need some test to ensure that the Sequence issue does not happen again. Maybe a Unit Test is good enough, to ensure that we are creating a good SQL

Thanks
Joao

On Wed, Feb 21, 2018 at 3:13 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patches,
1) To fix the validation issue while creating new sequence
RM#3014

2) Fix PEP-8 issues in sequence module
pycodestyle --config=.pycodestyle ./pgadmin/browser/server_groups/servers/databases/schemas/sequences/

3) To fix the regression test for Tablespace when running with Python3.x
RM#3138

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Joao De Almeida Pereira
Date:
Subject: Re: [pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence forencoding "LATIN1":0x00
Next
From: Joao De Almeida Pereira
Date:
Subject: Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)