Re: Move postgresql_fdw_validator into dblink - Mailing list pgsql-hackers

From Kohei KaiGai
Subject Re: Move postgresql_fdw_validator into dblink
Date
Msg-id CADyhKSU+G2F5yXoKC7MyGzSo4_zS-fQA6uwXGhiYM6-w-aFf6w@mail.gmail.com
Whole thread Raw
In response to Re: Move postgresql_fdw_validator into dblink  (Shigeru HANADA <shigeru.hanada@gmail.com>)
List pgsql-hackers
Hanada-san,

It is fair enough for me.
So, I'd like to hand over this patch for committers.

Thanks,

2012/10/9 Shigeru HANADA <shigeru.hanada@gmail.com>:
> (2012/10/09 0:30), Kohei KaiGai wrote:
>>
>> The attached patch is a revised one according to my previous
>> suggestion. It re-defines "PQconninfoOption *options" as static
>> variable with NULL initial value, then, PQconndefaults() shall
>> be invoked at once. The default options never changed during
>> duration of the backend process, so here is no reason why we
>> allocate and free this object for each validator invocation.
>
>
> Sorry for delayed response.  It seems reasonable, so I just fixed obsolete
> comment and indent.  Please see attached v3 patch which was rebased against
> latest head of master.
>
>
>> If it is also OK for you, I'd like to take over this patch to comitter.
>> This patch is prerequisite of postgresql_fdw, so I hope this patch
>> getting merged soon.
>
>
> Please go ahead. :-)
>
> Regards,
> --
> Shigeru HANADA
>



-- 
KaiGai Kohei <kaigai@kaigai.gr.jp>



pgsql-hackers by date:

Previous
From: Daniel Farina
Date:
Subject: Re: Detecting libpq connections improperly shared via fork()
Next
From: Vik Reykja
Date:
Subject: Re: Truncate if exists