Home > mailing lists

Re: [PROPOSAL] : Disallow use of empty column name in (column_name '') in ALTER or CREATE of foreign table. - Mailing list pgsql-hackers

From	Nishant Sharma
Subject	Re: [PROPOSAL] : Disallow use of empty column name in (column_name '') in ALTER or CREATE of foreign table.
Date	December 19 18:49:33
Msg-id	CADrsxdY3CUz2JhR5pNDCMrG2KpYztNtCZq_TRqiXZcq8__SEWg@mail.gmail.com Whole thread Raw
In response to	[PROPOSAL] : Disallow use of empty column name in (column_name '') in ALTER or CREATE of foreign table. (Nishant Sharma <nishant.sharma@enterprisedb.com>)
List	pgsql-hackers

Hi,

Summary of this thread-

Tom had the following concern:-

Regarding location of check in

ATExecAlterColumnGenericOptions. And spell check issue

comparison. Which I believe was addressed by v2 and

its response.

Ashutosh had the suggestion:-

Check should be delegated to an FDW validator. Which I

believe was addressed in v2.

Michael had the following concern:-

We should also care about empty values in schema_name

and table_name. Which I believe I have addressed in v3

patch.

Robert had the following concern:-

Regarding error message and single patch for this. Which I

believe I have addressed in v4 patch.

Tom, Ashutosh, Michael, Robert please let me know if I was

able to address your concerns or if you feel differently.

Assuming Tom, Ashutosh, Michael and Robert feel as though

I have addressed the concerns mentioned above, does anybody

have any additional feedback or concerns with this patch? If not,

I would request we move to commit phase.

Thank you!

Regards,

Nishant Sharma (EDB).

From: Peter Eisentraut
Date: 19 December, 18:48:24
Subject: Re: pure parsers and reentrant scanners

From: Peter Eisentraut
Date: 19 December, 18:51:13
Subject: Re: pure parsers and reentrant scanners