Re: Binary support for pgoutput plugin - Mailing list pgsql-hackers

From Dave Cramer
Subject Re: Binary support for pgoutput plugin
Date
Msg-id CADK3HH+DjY+rFDtZKLd-WTL6kat6eSW8D56+L81Tj0YjHJroPg@mail.gmail.com
Whole thread Raw
In response to Re: Binary support for pgoutput plugin  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Binary support for pgoutput plugin  (Dmitry Dolgov <9erthalion6@gmail.com>)
List pgsql-hackers


On Sun, 3 Nov 2019 at 21:47, Thomas Munro <thomas.munro@gmail.com> wrote:
On Thu, Oct 31, 2019 at 3:03 AM Dave Cramer <davecramer@gmail.com> wrote:
> Ok, I've rebased and reverted logicalrep_read_insert

Hi Dave,

From the code style police (actually just from cfbot, which is set up
to complain about declarations after statements, a bit of C99 we
aren't ready for):

proto.c:557:6: error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
      int len = pq_getmsgint(in, 4); /* read length */
      ^
proto.c:573:6: error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
      int len = pq_getmsgint(in, 4); /* read length */
      ^

Thomas,

Thanks for the review.

See attached
 
Attachment

pgsql-hackers by date:

Previous
From: Alexey Bashtanov
Date:
Subject: Re: log bind parameter values on error
Next
From: Dave Cramer
Date:
Subject: Re: let's make the list of reportable GUCs configurable (was Re: Add%r substitution for psql prompts to show recovery status)