Re: Binary support for pgoutput plugin - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Binary support for pgoutput plugin
Date
Msg-id CA+hUKGKC=Yu6ZG0=K4R++7pEgj5zJgMqsVbuoHjLUjVLXBoPZA@mail.gmail.com
Whole thread Raw
In response to Re: Binary support for pgoutput plugin  (Dave Cramer <davecramer@gmail.com>)
Responses Re: Binary support for pgoutput plugin  (Dave Cramer <davecramer@gmail.com>)
List pgsql-hackers
On Thu, Oct 31, 2019 at 3:03 AM Dave Cramer <davecramer@gmail.com> wrote:
> Ok, I've rebased and reverted logicalrep_read_insert

Hi Dave,

From the code style police (actually just from cfbot, which is set up
to complain about declarations after statements, a bit of C99 we
aren't ready for):

proto.c:557:6: error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
      int len = pq_getmsgint(in, 4); /* read length */
      ^
proto.c:573:6: error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
      int len = pq_getmsgint(in, 4); /* read length */
      ^



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: New SQL counter statistics view (pg_stat_sql)
Next
From: Tom Lane
Date:
Subject: TAP tests aren't using the magic words for Windows file access