Re: Replication slot drop message is sent after pgstats shutdown. - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Replication slot drop message is sent after pgstats shutdown.
Date
Msg-id CAD21AoDsx3Lg+0B2jt7oa-5_hmQ+xgA9V1s-8hXG++b8nEFt-w@mail.gmail.com
Whole thread Raw
In response to Re: Replication slot drop message is sent after pgstats shutdown.  (Andres Freund <andres@anarazel.de>)
Responses Re: Replication slot drop message is sent after pgstats shutdown.  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
On Tue, Aug 31, 2021 at 2:34 PM Andres Freund <andres@anarazel.de> wrote:
>
> On 2021-08-31 14:22:39 +0900, Masahiko Sawada wrote:
> > You mean to move only the part of sending the message to its own
> > before_shmem_exit() callback? or move ReplicationSlotRelease() and
> > ReplicationSlotCleanup() from ProcKill() to it?
>
> The latter.

Makes sense.

I've attached the patch that moves them to its own
before_shmem_exit(). Unless I missed to register the callback it works
the same as before except for where to release and clean up the slots.

Regards,

-- 
Masahiko Sawada
EDB:  https://www.enterprisedb.com/

Attachment

pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: Fix around conn_duration in pgbench
Next
From: Denis Hirn
Date:
Subject: Re: [PATCH] Allow multiple recursive self-references